Facebook SDK 4.1 #1051
Facebook SDK 4.1 #1051
Conversation
build.xml gets overwritten by cordova, so use the optional custom_rules.xml to declare java version
Adapting the MethodSwizzle technique used by the Parse cordova plugin (etc), we give ourselves access to methods from the AppDelegate, injecting them with our own behavior. Annoying that Cordova doesn’t provide this as part of their plugin interface; more and more SDKs expect you to call their own customized AppDelegate methods from the AppDelegate.
We don’t have an option here: to use the plugin on Android, the user must create an Application class and add our plugin’s static setup call to it.
|
It's an awesome pull request 👍 I'll try it |
|
is this supporting deferred deep linking? https://developers.facebook.com/docs/app-ads/deep-linking |
|
What's the state of this branch? If I just need to use facebook's app invites (which I see you've added), will I run into any trouble? |
|
We're currently using login, logEvent, api, and showDialog (appinvites) from this branch in production. The only functionality that is knowingly missing is related to the GameRequest and CreateAppGroup dialogs; they each have options that will require some explicit conversion (string to class type) to be populated from JSON. |
|
@ersingencturk, I didn't add any code to handle deferred deep linking, but this branch now contains the libraries necessary to do it (Bolts, FBSDKCoreKit), yes. |
|
@mereformalities Awesome, I'll give it a go then. |
|
@mereformalities, thanks for your response.I'll have a look |
|
@mereformalities Amazing work on getting this going. Anyone using this branch with success? |
|
@jamielob I've been using this branch for around 10 days as an in-place replacement and it has worked flawlessly! |
|
@Nicktho That's great! Are you using it for the login flow? If so, does it authenticate within the app without taking you away to the Facebook app? |
|
@mereformalities Great work. I'm kind of amazed we did the same work at roughly the same time! haha. Any interest in chatting about having one community-backed solution for Facebook SDK 4? (my fork is at https://github.com/jeduan/cordova-plugin-facebook4) |
|
@jamielob It bounces out to the native facebook app and then bounces back into the application. |
|
@Nicktho Thanks for letting me know. |
|
I am also very in favor of bringing the efforts together. Especially because of missing funcitonality (appinvites / other dialoges). So +1 for publishing your branch in the meantime on NPM, that others can use it in their build process. @mereformalities Does your version require Gradle for building and therefore phonegap-android > 4.0.0? |
|
Any update? Thanks. |
|
@mereformalities @ersingencturk @jeduan Can you give me code to handle deep linking? |
|
@mitiaptest That's currently not implemented in any plugin. If you want to take a stab at it, here's the docs on Facebook's end https://developers.facebook.com/docs/applinks/ios https://developers.facebook.com/docs/applinks/android |
|
Are the setup instructions in need of an update in order to work with this? I can't seem to get either iOS or Browser platforms to even load properly. |
|
@mereformalities would you mind giving this a small pull from master to update to the minor conflict in the readme? Also, would you be interested in helping to maintain this project? |
|
@aogilvie, working on resolving some conflicts with the develop branch. And yeah I'm interested! |
|
@jeduan, sorry I never got back to you! Great work. I'm available to help get a 4.x SDK solution finalized. |
|
@mereformalities BTW commits don't notify the maintainer, I don't think @jeduan ever saw that you did what they asked |
Here is an 'introductory' pull request to start the conversation of whether/how you'd like to see this branch modified/merged/contributed to. Sorry it took so long! Let me know how I can assist further.
Would you prefer to setup a facebook-sdk-4.1 branch at the base fork and continue work there? I could modify the pull request. I've pointed at develop as CONTRIBUTING.md suggested.