Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsafe implementations of Send & Sync #39

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove unsafe implementations of Send & Sync #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions wooting-analog-midi-core/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,11 +330,6 @@ pub struct MidiService {
pub note_config: NoteConfig,
}

//TODO: Determine if this is safe (LUL imagine saying it may be safe when it literally says unsafe) or a different solution is required
// Tbf haven't ran into any issues yet, so might be okay
unsafe impl Send for MidiService {}
unsafe impl Sync for MidiService {}

impl MidiService {
pub fn new() -> Self {
MidiService {
Expand Down