Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Github recommended supporting docs #211

Merged
merged 3 commits into from
Apr 25, 2023
Merged

Adds Github recommended supporting docs #211

merged 3 commits into from
Apr 25, 2023

Conversation

eidolonnight
Copy link
Collaborator

This adds code_of_conduct.md, contributing.md, and support.md files to the Marketing Team repo. These are recommended pages outlined under the Building communities Github documentation, and these should aid in directing new contributors to various resources. Links appear in various places within the team repository, including the sidebar when submitting new issues.

This initial commit creates basic pages with links to the handbook and other resources.

@eidolonnight eidolonnight added the documentation Improvements or additions to documentation label Apr 3, 2023
@eidolonnight eidolonnight self-assigned this Apr 3, 2023
@eidolonnight
Copy link
Collaborator Author

This pull request is the first half of work toward #140

@sereedmedia
Copy link
Contributor

Hi, thanks for tagging me! My comments:

  • There is an existing WordPress Code of Conduct. I am not okay with the Marketing Team adopting a unique Code of Conduct. Emphasis for emphasis. That is not something that can be maintained or enforced properly by the Marketing Team. Any Code of Conduct referenced or developed should apply project-wide. If we feel that we need a more specific Code of Conduct for contribution than what is covered in the existing WordPress Code of Conduct, then that is something we should bring up with the Community Team or discuss in the Team Reps channel.
  • The handbook link in Support resources is not linking properly.
  • I think linking back to the official WordPress.org site and marketing team handbook as you have done with the contributing and support pages is the best way to handle all of these docs, including (especially) the Code of Conduct. AFAIK, the Make Team Handbooks are currently the "single source of truth" for WordPress contribution.

Copy link
Contributor

@sereedmedia sereedmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot approve with the code of conduct text included.

@sereedmedia
Copy link
Contributor

Did an official review, but the same comments as my original. Redundancy is good for everyone and everybody!

@eidolonnight eidolonnight requested a review from sereedmedia April 6, 2023 17:44
Copy link
Contributor

@sereedmedia sereedmedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for using the direct link.

@sereedmedia
Copy link
Contributor

@jpantani can you review so we can get this closed and posted? it's super basic content.

Copy link

@jpantani jpantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good on my end.

@eidolonnight eidolonnight merged commit 8b95e3b into main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants