Skip to content
This repository has been archived by the owner on Nov 14, 2022. It is now read-only.

Switch to handle Core/5.6 compat now that Application Passwords is merged. #127

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

georgestephanis
Copy link
Collaborator

@georgestephanis georgestephanis commented Dec 12, 2020

  • Shift the classic plugin files into a subdirectory.
  • Make a new subdir for the newer implementation assets.
  • Have the main plugin loader file switch based on the core class being defined.

Goal for this PR is to still work as-previously for older versions of WP, but also seamlessly transition to a playground for future enhancement for for newer versions.

Still a WIP for now.

Things that the new compat mode for 5.6 should probably handle:

  • Redirect requests from the legacy auth_app admin page to the new core implementation.
  • Either reimplement the legacy endpoints, or provide a deprecation notice and details on the new ones?
  • Be a testing ground for new admin ui overhauls for the user profile screen or the like.

Fixes #124

Make a new subdir for the newer implementation assets.  And have the main plugin loader file switch based on the core class being defined.
Redirects to the new page.
@georgestephanis
Copy link
Collaborator Author

Tentative page looks something like this -- still open to just calling wp_safe_redirect() to pass the user along silently though. Not sure if this sort of interstitial would be better at prompting folks to update their urls in their apps.

Screen Shot 2020-12-12 at 3 36 48 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin for 5.6
1 participant