-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run PHPUnit on PHP >= 7.0 #86
Conversation
@adamziel Copying the CI setup from WordPress Core has proven itself to be much more difficult than we initially expected. At one point I had a bunch of code from a bunch of places throwing different errors for different PHP versions for different runs. I had to cut most of it out. Now I am adding it back again, but bit by bit, tackling each error one at a time. But, in the meantime, we can discuss some aspects of the PR. Namely: Separating concernsUsing the lib is distinctly different from contributing to it. For users - we could offer a For contributors - we could be centered around the dev (developing? development? contributing?) directory. With a separate (Actually, that is a topic robust enough, so I'll leave my questions at that.) |
Refactor tests for Yoast PHP Unit Polyfills
Agreed. That
Agreed
Primarily via a CLI script like |
I wonder if the remaining PHP 7.0 error is with the ZIP decoder, not the test setup. It should be fine to comment out those tests for now and address the issue separately. |
Sure. I'll circle back to the Zip tests later. So, what's enough for a merge here? |
So, it is not the stuff of legends after all... |
This is splendid @reimic! Thank you so much for all your hard work and dedication here, this one was a tough nut to crack and you did it! |
What does this PR do?
dev
directoryWhat problem does it fix?
How to test if it works?