Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry: Add links in site title and post title #186

Merged

Conversation

adrianaleites
Copy link
Contributor

  • Make site title link to home (in header template part).
  • Make post title a link (in index template).
  • Fix missing quotes in theme.json.
  • Update link colors.

Closes #181

- Make site title link to home (in header template part).
- Make post title a link (in index template).
- Fix missing quotes in theme.json.
- Update link colors.
- Fix templates header.html and index.html to link to the respective patterns, as it was originally.
- Adds the links in site title and post-title in the respective patterns instead.
@adrianaleites adrianaleites changed the title Poetry: Update header and index links (#181) Poetry: Add links in site title and post title May 20, 2024
Copy link
Collaborator

@MaggieCabrera MaggieCabrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! thank you so much @adrianaleites for your work here. Let's put the footer back and we can bring this in and merge

poetry/templates/index.html Outdated Show resolved Hide resolved
poetry/templates/index.html Outdated Show resolved Hide resolved
@MaggieCabrera MaggieCabrera merged commit 8ebac36 into WordPress:trunk May 21, 2024
1 check failed
@MaggieCabrera
Copy link
Collaborator

🎉

@adrianaleites
Copy link
Contributor Author

Thanks so much @MaggieCabrera for your guidance in my first pull request for an open source project.

@MaggieCabrera
Copy link
Collaborator

Thanks so much @MaggieCabrera for your guidance in my first pull request for an open source project.

you did amazing, let me know if I can assist with future contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Poetry: Add links in site title and post title
2 participants