Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term: Add Pattern Outlined Media & Text #194

Merged
merged 11 commits into from
Jun 18, 2024

Conversation

MaggieCabrera
Copy link
Collaborator

@MaggieCabrera MaggieCabrera commented Jun 4, 2024

Brings the changes from #153

Closes #107

Screenshot 2024-06-04 at 19 25 57

Copy link

github-actions bot commented Jun 4, 2024

Preview changes

I've detected changes to the following themes in this PR: Term.

You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@MaggieCabrera MaggieCabrera force-pushed the term-pattern-outlined-media-text branch from 74b705c to aa75e9b Compare June 4, 2024 17:18
@MaggieCabrera
Copy link
Collaborator Author

Can someone test this one for me, please?

@giacomo-secchi
Copy link

The image looks collapsed on mobile
demo-store local_

@shail-mehta
Copy link
Member

@MaggieCabrera

Can we use get_template_directory_uri() instead of get_stylesheet_directory_uri() ? because Term is Main Theme.

@MaggieCabrera MaggieCabrera force-pushed the term-pattern-outlined-media-text branch from c7b0e3e to 3e2da06 Compare June 18, 2024 14:03
@MaggieCabrera
Copy link
Collaborator Author

I added the changes here from #213 into this and changed the get_stylesheet_directory_uri to get_template_directory_uri

@MaggieCabrera MaggieCabrera merged commit 08a5f68 into trunk Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Term: Pattern Outlined Media & Text
3 participants