Move `duplicateTemplatePart` action to the `@wordpress/fields` package #65390

gigitux · 2024-09-17T08:05:08Z

Warning

This branch of this PR is based on #65289.

What?

This PR migrates the duplicateTemplatePart action to the @wordpress/fields package. The primary issue with this action is its dependency on the CreateTemplatePartModalContents component, which resides in the @wordpress/editor package. Due to this, it can't be directly used within the @wordpress/fields package.

For the purpose of the @wordpress/fields package work, I have temporarily moved the component to this package. However, I'm not certain if this is the best long-term solution. Ideally, this component (and potentially others) should reside in a dedicated package, such as @wordpress/template, which would be more appropriate for components related to template and template-parts. A similar package for the patterns already exists: https://github.com/WordPress/gutenberg/blob/d6fcf4aea4aff17cf0910862bf10090e20ba2ab0/packages/patterns/src

Please review and provide feedback on whether this approach is suitable or if there are alternative recommendations for handling these dependencies. Thanks! 🙏 cc @youknowriad @oandregal

Testing Instructions

Ensure that Custom Dataviews is enabled.

Visit the Site Editor.
Visit the patterns view.
Click on header
Duplicate a header template part.
Ensure that the duplicated template part is created.

Testing Instructions for Keyboard

Screenshots or screencast

…n-dataviews

…n-dataviews-2

gigitux · 2024-09-17T08:05:58Z

packages/fields/src/components/create-template-part-modal/index.tsx

@@ -152,10 +208,14 @@ export function CreateTemplatePartModalContents( {
 						label={ __( 'Area' ) }
 						className="editor-create-template-part-modal__area-radio-group"


Should I update these classes even if it is a temporary solution?

Yeah I think we should update them ideally fields instead of editor basically.

I updated it with 199c313

… into add/action-dataviews-3

oandregal · 2024-09-25T14:51:44Z

@gigitux what's the status on this one? I saw #65289 has been approved but not merged yet.

…n-dataviews-3

gigitux · 2024-09-25T15:17:27Z

@gigitux what's the status on this one? I saw #65289 has been approved but not merged yet.

@oandregal I rebased this PR after #65289 has been merged. Let me know if you agree with the current method, or if you believe a dedicated package should be created for these template-related components.

P.S: As reminder, we are in cooldown, so I'm not strictly focused on this project. I may be slow (I will do my best) on checking your feedback 🙇

…n-dataviews-3

gigitux · 2024-10-24T08:03:41Z

I rebased this PR and it is ready to be reviewed. My main concern is this one:

For the purpose of the @wordpress/fields package work, I have temporarily moved the component to this package. However, I'm not certain if this is the best long-term solution. Ideally, this component (and potentially others) should reside in a dedicated package, such as @wordpress/template, which would be more appropriate for components related to template and template-parts. A similar package for the patterns already exists: https://github.com/WordPress/gutenberg/blob/d6fcf4aea4aff17cf0910862bf10090e20ba2ab0/packages/patterns/src

github-actions · 2024-10-24T08:04:31Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: gigitux <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: oandregal <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

youknowriad · 2024-10-24T10:20:09Z

packages/editor/src/components/template-part-menu-items/convert-to-template-part.js

@@ -13,7 +13,7 @@ import { symbolFilled } from '@wordpress/icons';
 /**
 * Internal dependencies
 */
-import CreateTemplatePartModal from '../create-template-part-modal';
+import { CreateTemplatePartModal } from '@wordpress/fields';


Yes, I agree this is weird, but also not sure what's the best place for these wp-core-data aware components. That said I can live with it being in fields for now.

Maybe we should add a comment explaining the choice.

With 47da440 I added some documentation.

youknowriad · 2024-10-24T10:22:18Z

packages/fields/src/constants.ts

+	plugin: 'plugin',
+};
+
+export const TEMPLATE_PART_AREA_DEFAULT_CATEGORY = 'uncategorized';


Personally I hate these constants file and would rather mostly remove them (especially since most of these types are "typed" now.

Removed with 64423cf

youknowriad · 2024-10-24T10:33:07Z

packages/fields/src/components/create-template-part-modal/index.tsx

 		[]
 	);
+
+	const defaultTemplatePartAreas = getDefaultTemplatePartAreas( settings );


Personally, I think this is the wrong solution to retrieving the default template areas. There might not be a rendered block-editor when using the fields, so I don't think a dependency to "block-editor" is the right approach.

The main issue here is that defaultTemplateTypes and defaultTemplatePartAreas are passed from the server to the client through the editor settings initialization. I think this is the wrong approach. The right approach would be to move these to getEntityRecord( 'root', '__unstableBase' ) endpoint and add them in the server to this endpoint. I believe we did things like that in the past for things like site_icon_url ... Do you think this is something we can try in its own PR. I'm a bit concerned that the current field won't work as expected in all contexts.

Do you think this is something we can try in its own PR. I'm a bit concerned that the current field won't work as expected in all contexts.

I'm happy to work on it with a dedicated PR! 💪

I created #66459. Let me know if you agree with the approach that I took!

…n-dataviews-3

gigitux added 26 commits September 12, 2024 09:33

Migrate store and actions from editor package to fields package

67ff043

fix documentation

a71e726

fix import

0141d8c

remove duplicate code

f21a974

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

7063ee8

…n-dataviews

update package-lock

644dab1

refactor PR

3616964

fix mobile build

f7f1d4d

update package.json

ae0efeb

migrate actions to @wordpress/fields package

4356a42

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

bf1462a

…n-dataviews-2

reduce change

63adf35

register new action

c938a15

improve code

66479da

fix actionId

0bf760d

update package-lock.json

08bb03d

remove comment

b599c42

rename function

337b3e5

rename functions

1016ef8

improve code

39d25d1

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

dc03f57

…n-dataviews-2

Migrate duplicate-template-part action to @wordpress/fields package

599c0a4

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

60e7a58

…n-dataviews-2

fix build

81c0980

restore files

7b2bb82

fix CSS

d6fcf4a

gigitux commented Sep 17, 2024

View reviewed changes

gigitux added 3 commits September 18, 2024 11:15

restore delete post action

0316536

fix import order

485237f

move to a flat structure

5a4fb59

gigitux added 2 commits September 18, 2024 14:10

remove not necessary file

0deeed3

Merge branch 'add/action-dataviews-2' of github.com:gigitux/gutenberg…

d42430d

… into add/action-dataviews-3

gigitux mentioned this pull request Sep 25, 2024

Migrate store/actions from editor package to fields package #65289

Merged

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

400a67d

…n-dataviews-3

gigitux added 2 commits October 1, 2024 15:08

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

18d6029

…n-dataviews-3

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

ff299b6

…n-dataviews-3

gigitux requested review from youknowriad, oandregal and louwie17 October 24, 2024 08:03

gigitux self-assigned this Oct 24, 2024

gigitux added [Type] Experimental Experimental feature or API. [Package] DataViews /packages/dataviews labels Oct 24, 2024

gigitux marked this pull request as ready for review October 24, 2024 08:04

regenerate package-lock.json file

36adb07

youknowriad reviewed Oct 24, 2024

View reviewed changes

gigitux added 4 commits October 24, 2024 14:59

generate documentation

47da440

delete constant file

64423cf

update class

199c313

rename styles.scss to style.scss

8571360

gigitux mentioned this pull request Oct 25, 2024

Move default template types and template part areas to REST API #66459

Open

gigitux added 2 commits October 28, 2024 12:23

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

844a98a

…n-dataviews-3

Merge branch 'trunk' of github.com:WordPress/gutenberg into add/actio…

0bd24a7

…n-dataviews-3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move `duplicateTemplatePart` action to the `@wordpress/fields` package #65390

Move `duplicateTemplatePart` action to the `@wordpress/fields` package #65390

gigitux commented Sep 17, 2024 •

edited

Loading

gigitux Sep 17, 2024 •

edited

Loading

youknowriad Oct 24, 2024

gigitux Oct 25, 2024

oandregal commented Sep 25, 2024

gigitux commented Sep 25, 2024

gigitux commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 •

edited

Loading

youknowriad Oct 24, 2024

youknowriad Oct 24, 2024

gigitux Oct 24, 2024

youknowriad Oct 24, 2024

gigitux Oct 24, 2024

youknowriad Oct 24, 2024

gigitux Oct 24, 2024

gigitux Oct 25, 2024

		@@ -152,10 +208,14 @@ export function CreateTemplatePartModalContents( {
		label={ __( 'Area' ) }
		className="editor-create-template-part-modal__area-radio-group"

Move duplicateTemplatePart action to the @wordpress/fields package #65390

Are you sure you want to change the base?

Move duplicateTemplatePart action to the @wordpress/fields package #65390

Conversation

gigitux commented Sep 17, 2024 • edited Loading

What?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

gigitux Sep 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

oandregal commented Sep 25, 2024

gigitux commented Sep 25, 2024

gigitux commented Oct 24, 2024

github-actions bot commented Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Move `duplicateTemplatePart` action to the `@wordpress/fields` package #65390

Move `duplicateTemplatePart` action to the `@wordpress/fields` package #65390

gigitux commented Sep 17, 2024 •

edited

Loading

gigitux Sep 17, 2024 •

edited

Loading

github-actions bot commented Oct 24, 2024 •

edited

Loading