[WIP] Block editor: Add MediaUploadProvider
#66380
Draft
+170
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
[Type] Enhancement
|
@youknowriad Is this roughly what you had in mind? |
|
Size Change: +417 B (+0.02%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
swissspidy
force-pushed
the
add/61447-media-upload-provider
branch
2 times, most recently
from
a810b80
to
fe31fbf
Compare
youknowriad
reviewed
Oct 24, 2024
Correct me if I'm wrong but for me the setting passed to the block editor, shouldn't use any store. It's a setting that will be used internally by the new package to actually perform the upload right? |
|
Yes. What I mean by this is: The function passed to the block editor will be passed on unmodified to the upload store for eventually uploading the file to the server. Now, if someone, for example the image block, calls I just need to figure out how to best do that :) |
youknowriad
approved these changes
Oct 24, 2024
|
Awesome, thanks! Yeah let's review the other PR first to make things easier :) Appreciate any eyes there. |
swissspidy
force-pushed
the
add/61447-media-upload-provider
branch
from
7d3f04d
to
52288c5
Compare
sirreal
reviewed
Nov 5, 2024
packages/upload-media/src/components/provider/with-registry-provider.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Jon Surrell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This is still work in progress and still incomplete!
What?
Adds a new
MediaUploadProvidercomponent toblock-editorto leverage the new upload data store from the experimentalupload-mediapackage added in #66290.To-do:
getSettings().mediaUploadin theblock-editorpackage to use this new upload store (it should look like https://github.com/swissspidy/media-experiments/blob/8b64ed6150aca612cc649f32861c8049e79cd985/packages/editor/src/init/editor/media-upload.ts#L21-L109)Why?
Every block editor instance should have its own upload store instance
How?
Follows the recommendation from #66290 (comment) to implement
MediaUploadProviderwithuseSubRegistry.Testing Instructions
Tests should still pass
Everything should still work with the experiment being disabled
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A