Perf metrics: update select and other metrics to use non-empty paragraphs #66762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.82 MB ℹ️ View Unchanged
|
|
Cc @youknowriad in case you have an opinion |
Mamaduka
reviewed
Nov 5, 2024
| @@ -270,7 +270,7 @@ test.describe( 'Post Editor Performance', () => { | |||
| const canvas = await perfUtils.getCanvas(); | |||
|
|
|||
| const paragraphs = canvas.getByRole( 'document', { | |||
| name: /Empty block/i, | |||
| name: /Block: Paragraph/i, | |||
There was a problem hiding this comment.
I always forget the rule when we should make labels compatible with old branches, but this seems to be okay since tests create the fixtures.
There was a problem hiding this comment.
Yes, it shouldn't be needed since in both environments we create filled paragraphs now.
|
I'm ok with this change :) |
|
Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
#66636 caused an increase in the "select" metric simply be restoring the empty paragraph inserter. This made me realise that the paragraphs used in the test are all empty!
Why would this be a real scenario? Most blocks that someone will select will NOT be empty. The empty paragraph (default block) is actually an exception in many ways: we do not render the block toolbar, and we do render the inserter. Why would we want to test an exception?
I don't see how a 1000 empty paragraphs a good scenario for any perf test, so I changed the util.
Why?
Unrealistic performance test.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast