Select Mode: Hide tool selector in the post editor and force design mode #66784
+31
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +61 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Nov 6, 2024
| return select( preferencesStore ).get( 'core', 'editorTool' ); | ||
| ( select ) => ( state ) => { | ||
| return ( | ||
| state.settings.editorTool ?? |
There was a problem hiding this comment.
I like that approach where we don't mess with the preference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #66775
What?
The "write/design" mode selector doesn't make a lot of sense in the post editor when only seeing posts and pages... This PR hides the tool selector and forces full design mode in this case.
An exception exists for wp_template post type.
Testing Instructions
1- Open the post editor
2- Notice there's no tool selector
3- Toggle the "show template" in the sidebar
4- The tool selector appears and you can switch to "write" mode
5- Toggle the template off, and notice that you're back in "design" mode with the tool selector hidden.