Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Default and Plain Styles from Quote Block #68457

Open
wants to merge 33 commits into
base: trunk
Choose a base branch
from

Conversation

karthick-murugan
Copy link
Contributor

What?

Fixes #49776

This PR removes the "Plain" style from the core Quote block by eliminating it from the block.json file.

Why?

The styles for "Default" and "Plain" did not offer significant visual differentiation, causing unnecessary complexity. Removing these ensures a simpler, more consistent block styling that aligns with the direction of block-based themes, which avoid relying on bundled styles.

How?

The block editor block styles definitions for both "Default" and "Plain" variations were removed from the Quote block's styles component in the block.json file. This simplifies the block's styling and improves compatibility with modern block themes.

Testing Instructions

  1. Open the WordPress editor (post or page).
  2. Insert a Quote block.
  3. Verify that the "Default" and "Plain" style variations are no longer available.
  4. Observe that the block renders consistently across different themes, regardless of their support for wp-block-styles.

Screenshots or screencast

Before

style_before_removal

After

styles_removed

Copy link

github-actions bot commented Jan 2, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: karthick-murugan <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: richtabor <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@karthick-murugan karthick-murugan changed the title Update/quote block styles Remove Default and Plain Styles from Quote Block Jan 2, 2025
@akasunil akasunil added [Type] Bug An existing feature does not function as intended [Block] Quote Affects the Quote Block labels Jan 6, 2025
@carolinan carolinan added the Needs Decision Needs a decision to be actionable or relevant label Jan 23, 2025
@carolinan
Copy link
Contributor

carolinan commented Jan 23, 2025

Hi
If we want to move forward with this, let's add another comment to the theme.scss file that the CSS is kept for backwards compatibility.

There are tests related to the style variations that use this style, these needs to be updated.
The tests should not be removed -they test variations, not the quote block itself.

There is also documentation for variations that use this style as an example, it needs to be updated:
\docs\how-to-guides\themes\global-settings-and-styles.md

@carolinan carolinan removed the Needs Decision Needs a decision to be actionable or relevant label Jan 25, 2025
@carolinan carolinan added Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quote block: Missing styles and no difference between Default and Plain variations
3 participants