Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check including libraries already in wp core including jquery #715

Merged
merged 17 commits into from
Nov 4, 2024
Merged

Check including libraries already in wp core including jquery #715

merged 17 commits into from
Nov 4, 2024

Conversation

davidperezgar
Copy link
Member

Fixes #702

@davidperezgar davidperezgar linked an issue Oct 11, 2024 that may be closed by this pull request
Check: Including Libraries Already In WP Core (including jquery) #702
Closed
@davidperezgar davidperezgar self-assigned this Oct 24, 2024
@davidperezgar davidperezgar marked this pull request as ready for review October 24, 2024 21:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 24, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar
Copy link
Member Author

How can i disable the spell check in one line?

@ernilambar
Copy link
Member

How can i disable the spell check in one line?

This seems to false positive and issue seems to be filed crate-ci/typos#1103

Not sure when that will be fixed. For current fix we could add toml file.

Documentation: https://github.com/crate-ci/typos?tab=readme-ov-file#false-positives

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Oct 29, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Oct 29, 2024
@davidperezgar
Copy link
Member Author

Thanks @ernilambar

@davidperezgar davidperezgar merged commit aeedd2f into trunk Nov 4, 2024
27 checks passed
@davidperezgar davidperezgar deleted the 702-check-including-libraries-already-in-wp-core-including-jquery branch November 4, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ernilambar ernilambar ernilambar approved these changes

@swissspidy swissspidy swissspidy approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

Assignees

@davidperezgar davidperezgar

Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Check: Including Libraries Already In WP Core (including jquery)
3 participants
@davidperezgar @ernilambar @swissspidy