Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Remove text color from the term description block #656

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

carolinan
Copy link
Contributor

Description
By removing the text color from the term description block, the number of color contrast issues when the block is used in a "section" is reduced.

Closes #655

Screenshots
Because of the large number of contrast issues, I will not provide screenshots or videos of all before and after scenarios.
After

term-description-color.mp4

Testing Instructions
The term description block is easiest to test on archive templates, since this type of template is the only template that shows the block on the front.

Go to Appearance > Editor > Templates
Select to edit the archive template.
This template already has a term description block placed, but to test the colors, you need to place it inside a group (or column) with a section style applied.

Then change the section style and the theme style variation to test the possible combinations.

Verified

This commit was signed with the committer’s verified signature.
fritzy Nathan Fritz
@carolinan carolinan added the [Type] Bug An existing feature does not function as intended. label Oct 29, 2024
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

Screen.Recording.2024-10-29.at.17.51.54.mov

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@juanfra juanfra merged commit 9b765dc into trunk Oct 29, 2024
5 of 6 checks passed
@juanfra juanfra deleted the update/term-description-color branch October 29, 2024 16:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Term description has too low color contrast on some style variations
2 participants