Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render_block_context
another approach that solve the context issue #7522base: trunk
Are you sure you want to change the base?
render_block_context
another approach that solve the context issue #7522Changes from 21 commits
3bf219c
7b54206
dbd6126
c229a57
a95ca1d
976d7d6
adf52a7
d410a3c
b0af042
a6db0fd
5cbb114
898d29c
fc76e2c
40bfc5e
f50736d
ec2c0ab
e1203be
218b887
33930ed
192e5ae
819e9db
dc6577b
28ce083
2c46470
9764c52
de703d9
6c4f6cd
c7c5418
dce8002
22772c1
c83ca82
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line doesn't look right to me. If we want to update
$available_context
based on$context
, this should happen within therefresh_context_dependents()
because then$available_context
is a dependent of$context
.