-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load fonts from style variations in the editor and the admin #7581
Load fonts from style variations in the editor and the admin #7581
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @matiasbenedetto! I've left some feedback on improving a unit test.
tests/phpunit/tests/fonts/font-face/wp-font-face-tests-dataset.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me and tests well.
I took the liberty of pushing some changes to the tests to allow for commit:
- fix the path to allow for testing on various systems per https://make.wordpress.org/hosting/test-results/ (and local dev environments that don't use docker)
- pushed a few docblocks to the tests
This seems to mostly work in WordPress 6.7 now: WordPress/wordpress-develop#7581
What:
Load fonts from style variations only in the editor and admin, not in the public frontend.
This is an alternative and probably simpler alternative to the Gutenberg PR: WordPress/gutenberg#65019 and it core port PR: #7570
Trac ticket: https://core.trac.wordpress.org/ticket/62231
Testing Instructions:
Try to load a style variation and check that the fonts referenced in those style variations load as expected.
I created a theme to test this quickly and visually:
font-variants.zip
In this theme, the alternative font families and font faces with theme-relative URLs are defined in the style variations.
Sceencast
2024-10-17.11-10-40.mp4