REST API code optimizations #7682
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
anton-vlasenko
force-pushed
the
fix/refactor-code-in-rest-api-controllers
branch
from
b316c0b
to
d62c3eb
Compare
2. Refactor complex `if/continue` statements into two simpler `continue` statements. 3. Refactor return values in certain methods, such as creating arrays all at once instead of adding values to an array one by one.
2. Reorders order of expressions in if conditions to optimize performance. 3. Fixes issues with callling stating methods dynamically and non-static method statically. 4. Merges isset() and unset() statements. 5. Explicitly return null in WP_REST_Posts_Controller::handle_terms().
anton-vlasenko
force-pushed
the
fix/refactor-code-in-rest-api-controllers
branch
from
b9e67db
to
f0ae81d
Compare
|
This PR was created for organizational purposes and has fulfilled its role. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't review or merge.
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.