Fix: wp_delete_attachment to Handle Non-Standard Taxonomies

[Debarghya-Banerjee]

Trac Ticket: Core-36437

Description:

• This pull request addresses an issue with the wp_delete_attachment function, which assumes that attachments use the category and post_tag taxonomies. This assumption can lead to warnings in wp_delete_object_term_relationships when the attachment's post type does not utilize these taxonomies.

Changes Made:

• Updated the wp_delete_attachment function to check for existing taxonomies associated with the post type. This ensures that only relevant taxonomies are used when deleting term relationships, preventing unnecessary warnings.

• Removed hardcoded references to category and post_tag, allowing the function to dynamically handle any taxonomies related to the attachment's post type.

• Added unit tests to verify the new behavior, ensuring that attachments can be deleted without warnings even when custom taxonomies are used. The tests confirm that the function behaves correctly when no terms are associated with the attachment.

Testing:

• All existing and new unit tests have been executed successfully, confirming that the changes do not introduce any regressions and that the new functionality works as intended.

Conclusion:

• These changes enhance the robustness of the wp_delete_attachment function, making it more flexible and ensuring it can handle a wider range of use cases without generating warnings. Thank you for considering this pull request!

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.