Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Add medium_large size for wp_prepare_attachment_for_js() #7709

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Debarghya-Banerjee
Copy link

Trac Ticket: Core-43413

Overview

  • This pull request introduces the addition of the medium_large image size to the wp_prepare_attachment_for_js function in WordPress. This enhancement allows for better handling and retrieval of the medium_large image size in the JavaScript context, providing developers with more flexibility when working with media attachments.

Changes Made

  • Modified the wp_prepare_attachment_for_js function to include the medium_large image size.
    Ensured that the new size is appropriately registered and available for use in the media library.

Benefits

  • Improved Media Management: By including the medium_large size, users can more effectively manage and display images without needing to generate additional sizes manually.

  • Better Performance: Utilizing the appropriate image size can improve page load times and overall performance, particularly on responsive designs where image dimensions are critical.

Copy link

github-actions bot commented Nov 3, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props debarghyabanerjee.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Nov 3, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant