Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined array key 'host' in canonical.php #7726

Closed

Conversation

geekofshire
Copy link

This PR addresses PHP warnings in the WordPress canonical.php file related to undefined host and scheme array keys, particularly in environments using HTTP/3 (QUIC) with Nginx, where these headers may be inconsistently set.

To resolve these warnings, fallback values have been introduced for the host and scheme keys as follows:

  • host: Defaults to an empty string ('') if not set. This prevents undefined key errors while allowing flexibility in URL handling logic.
  • scheme: Defaults to 'http' if not set. This ensures URLs are built with a valid protocol if the scheme is missing.
    These changes prevent PHP warnings while maintaining backward compatibility across HTTP/1.1, HTTP/2, and HTTP/3 requests.

Trac ticket: https://core.trac.wordpress.org/ticket/62334


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

- add an empty string as fallback for 'host' key
- add 'http' as default fallback for 'scheme' key
Copy link

github-actions bot commented Nov 5, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props geekofshire.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Nov 5, 2024

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@geekofshire geekofshire closed this Nov 5, 2024
@geekofshire geekofshire deleted the fix/undefined-host-warning branch November 5, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant