Fix undefined array key 'host' in canonical.php #7726
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses PHP warnings in the WordPress canonical.php file related to undefined host and scheme array keys, particularly in environments using HTTP/3 (QUIC) with Nginx, where these headers may be inconsistently set.
To resolve these warnings, fallback values have been introduced for the host and scheme keys as follows:
host
: Defaults to an empty string ('') if not set. This prevents undefined key errors while allowing flexibility in URL handling logic.scheme
: Defaults to 'http' if not set. This ensures URLs are built with a valid protocol if the scheme is missing.These changes prevent PHP warnings while maintaining backward compatibility across HTTP/1.1, HTTP/2, and HTTP/3 requests.
Trac ticket: https://core.trac.wordpress.org/ticket/62334
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.