Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Pullquote citation color reflects selected text color #8018

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@
@include font-family( $font__heading );
line-height: 1.6;
text-transform: none;
color: $color__text-light;
color: inherit;

/*
* This requires a rem-based font size calculation instead of our normal em-based one,
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentynineteen/style-editor.css
Original file line number Diff line number Diff line change
Expand Up @@ -1100,7 +1100,7 @@ figcaption,
}

.wp-block-pullquote:not(.is-style-solid-color) .wp-block-pullquote__citation {
color: #767676;
color: inherit;
}

.wp-block-pullquote.is-style-solid-color blockquote {
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentynineteen/style-editor.scss
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,7 @@ figcaption,
}

&:not(.is-style-solid-color) .wp-block-pullquote__citation {
color: $color__text-light;
color: inherit;
}

&.is-style-solid-color {
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentynineteen/style-rtl.css
Original file line number Diff line number Diff line change
Expand Up @@ -5732,7 +5732,7 @@ body.page .main-navigation {
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
line-height: 1.6;
text-transform: none;
color: #767676;
color: inherit;
/*
* This requires a rem-based font size calculation instead of our normal em-based one,
* because the cite tag sometimes gets wrapped in a p tag. This is equivalent to $font-size_xs.
Expand Down
2 changes: 1 addition & 1 deletion src/wp-content/themes/twentynineteen/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -5744,7 +5744,7 @@ body.page .main-navigation {
font-family: -apple-system, BlinkMacSystemFont, "Segoe UI", "Roboto", "Oxygen", "Ubuntu", "Cantarell", "Fira Sans", "Droid Sans", "Helvetica Neue", sans-serif;
line-height: 1.6;
text-transform: none;
color: #767676;
color: inherit;
/*
* This requires a rem-based font size calculation instead of our normal em-based one,
* because the cite tag sometimes gets wrapped in a p tag. This is equivalent to $font-size_xs.
Expand Down
Loading