-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
White background + welcome widget border #8152
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @[email protected]. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
I pushed a follow-up commit to the PR to also use white background on alternative color schemes. Maybe we can choose to keep a grey background on some of them, though. |
@karmatosed do you have any preference for the welcome box? Black border or no border? |
Noting that I am approving this review as did on trac here also. The idea is to remove the border. |
This is related to https://core.trac.wordpress.org/ticket/62831.
I noticed that the white background was removing the background difference between the welcome panel (the section with a white background).
While it doesn't look shocking to me, this PR also adds a border to the welcome widget.
This is the only issue I found while testing this changeset.
More tests are welcome!