Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test plugin for WordPress 6.6.2 and 6.7-beta2 #174

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

zaerl
Copy link
Contributor

@zaerl zaerl commented Oct 15, 2024

This PR updates the Tested up to label to WordPress 6.7-beta2.

Tested with WordPress 6.6.2 and 6.7-beta2
Tested with PHP 7.0, 7.4, 8.0, 8.2, 8.3

How to test:

  1. Clone the plugin under your working directory
  2. Using wp-env to test, if you haven't installed it, please visit wp-env for instructions
    It'll be easier to have a .wp-env.json file in the root folder. For example, if your root folder is blogger-importer, you can clone the plugin under this folder. Create a .wp-env.json file; you can change the PHP version to the one you want to test with.
{
  "phpVersion": "7.4",
  "plugins": ["./wordpress-importer"]
}

Run wp-env start to spin up the WordPress.

Navigate to http://localhost:8888/wp-admin/admin.php?import=wordpress and upload a file.
Import the content using the download attachment option and without.. it can take a while if you have a lot of content. If the script timeout, you need to set_time_limit to a higher value.

Check and see if the import works fine without errors and warnings.

@zaerl zaerl requested review from ouikhuan and bogiii October 15, 2024 08:13
@zaerl zaerl self-assigned this Oct 15, 2024
Copy link
Member

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress 6.7 is due to be released in ~1 month, It would be ideal if we could test and bump this to that instead.

Are you able to test with the latest Beta?

src/readme.txt Outdated Show resolved Hide resolved
@zaerl
Copy link
Contributor Author

zaerl commented Oct 15, 2024

Are you able to test with the latest Beta?

Good idea. There is no problem with testing with 6.7.

@zaerl zaerl requested a review from dd32 October 15, 2024 08:37
@zaerl zaerl changed the title Test plugin for WordPress 6.6.2 Test plugin for WordPress 6.6.2 and 6.7-beta2 Oct 15, 2024
Copy link
Member

@dd32 dd32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@dd32 dd32 merged commit 671c34a into master Oct 15, 2024
26 checks passed
@dd32 dd32 deleted the update/tested-up-to-6-6-2 branch October 15, 2024 08:43
@zaerl
Copy link
Contributor Author

zaerl commented Oct 17, 2024

@dd32 the update step didn't pass. Is it ok to create a 0.8.3 to incorporate the changes made after 0.8.2?

@dd32
Copy link
Member

dd32 commented Oct 17, 2024

#163 is the only change other than tested up to.

If you think it's worthwhile, I guess a new minor can be released. Otherwise a plugins admin can bump the tested metadata manually.

(I can't view the logs mobile, I assume the action failed for some mundane reason)

@zaerl
Copy link
Contributor Author

zaerl commented Oct 17, 2024

Ok, thanks. It complains about other files that have been changed and nothing more.

svn: warning: W155010: The node '/home/runner/svn-wordpress-importer/trunk/vendor/composer' was not found.
svn: warning: W155010: The node '/home/runner/svn-wordpress-importer/trunk/vendor/autoload.php' was not found.
?       trunk/.wordpress-org
?       trunk/LICENSE
?       trunk/README.md
!       trunk/class-wp-import.php
!       trunk/compat.php
!       trunk/parsers
!       trunk/parsers/class-wxr-parser-regex.php
!       trunk/parsers/class-wxr-parser-simplexml.php
!       trunk/parsers/class-wxr-parser-xml.php
!       trunk/parsers/class-wxr-parser.php
!       trunk/parsers.php
!       trunk/readme.txt
?       trunk/src
M       trunk/wordpress-importer.php
🛑 Other files have been modified; changes not deployed

@zaerl zaerl mentioned this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants