Extend notification model with optional properties. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th several fields
raaaahman
added
enhancement
3 tasks
|
Replaced by #63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
The
WP_Notify_Base_Notificationmodel was not up-to-date with the optional fields defined in PR #21See #60
Changes
title,imageandaction_linkproperties as decorators to theWP_Notify_Base_Notificationclass.imagefield in the database scheme.Current limitations
The unserialization of the decorated notifications is not ready yet. It is debatable if this would be used at all (receiving notification data from the front-end), but on another hand, it would be better to keep this possibility open at such an early stage of development...