Fix accessibility scan failures #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwoodnz
commented
Dec 5, 2023
| @@ -29,7 +30,6 @@ | |||
| border-radius: 2px; | |||
| margin-right: 8px; | |||
| padding: 2px 8px; | |||
| font-size: var(--wp--preset--font-size--small); | |||
There was a problem hiding this comment.
Size is already small
adamwoodnz
commented
Dec 5, 2023
source/wp-content/themes/wporg-developer-2023/src/code-short-title/style.scss
Outdated
Show resolved
Hide resolved
adamwoodnz
added
Accessibility
adamwoodnz
force-pushed
the
fix/179-accessibility-scan-failures
branch
2 times, most recently
from
d32e0dd to
c8e1f09
Compare
adamwoodnz
force-pushed
the
fix/179-accessibility-scan-failures
branch
from
c8e1f09 to
88565dd
Compare
adamwoodnz
commented
Dec 11, 2023
| } | ||
| ] | ||
| }, | ||
| "custom": { | ||
| "color": { |
There was a problem hiding this comment.
Colors picked from existing sass palette which is unused in the new theme.
Only adding what we need for now.
Adding to custom means they are available for semantic colors in blocks but don't show in the editor palette.
renintw
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179
Includes fixes for
Contrast fixes are achieved by darkening the
typetext within the chip, using color shades already defined in the previous theme and ported into theme.json for reuse.Screenshots
Testing
Use Lighthouse or Axe Devtools to scan:
Scan should pass on the above items. There are outstanding issues on WP_Query which are being covered elsewhere (#413, #426)