Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing issues on wordpress.org #120

Closed
critterverse opened this issue Sep 12, 2022 · 6 comments
Closed

Fix spacing issues on wordpress.org #120

critterverse opened this issue Sep 12, 2022 · 6 comments

Comments

@critterverse
Copy link

Some spacing issues seem to have popped up on wp.org in the last 24-48 hours. It looks like some inline styling may be being overridden and/or a spacing variable missing:

image
image (1)

@Otto42
Copy link
Member

Otto42 commented Sep 12, 2022

Which spacing is wrong? I'm not particularly familiar with the new homepage, and realistically, don't see any problems with the screenshots.

So, it would help to be very specific.

@critterverse
Copy link
Author

Items like text, buttons, and sections shouldn't be flush against each other. The correct spacing can be seen in this Figma file for reference: https://www.figma.com/file/WHhRwVc4swYnPKdyVWj3du/Home-%26-Download-Pages?node-id=0%3A1

@jeffikus
Copy link

For the hero and the Build for yourself areas, the padding seems to be overridden by !important styles coming in from I'm not sure where. For example, on the hero;

[style*="padding-bottom:120px"] { padding-bottom: var(--wp--preset--spacing--80) !important; }

That is overriding the inline styles of the #intro div
padding-top:120px;padding-right:0px;padding-bottom:120px;padding-left:0px

I'm not sure the history there, but that's what seems to be the cause.

@adamwoodnz
Copy link
Contributor

The spacing variable --wp--preset--spacing--80 is now undefined. It should be coming from the parent theme as defined here as I understand it

@adamwoodnz
Copy link
Contributor

Fixed by reactivating the Gutenberg plugin. We'll put something in place to avoid it happening again.

@tellyworth
Copy link
Contributor

Related: WordPress/wporg-parent-2021#45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants