Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spacing of elements on frontend #121

Closed
wants to merge 1 commit into from
Closed

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Sep 12, 2022

Temporarily fixes #120

Spacing variables which are supposed to come from the parent theme are undefined.

Vars copied from https://github.com/WordPress/wporg-parent-2021/blob/trunk/source/wp-content/themes/wporg-parent-2021/theme.json#L466

Screenshots

Before After
Screen Shot 2022-09-13 at 10 00 05 AM Screen Shot 2022-09-13 at 10 00 36 AM

How to test

  1. Copy main.css into the main theme in your w.org sandbox
  2. Observe that paddings are restored in front page
  3. Also check at mobile size
  4. Check Download page too

@adamwoodnz adamwoodnz added [Type] Bug Something isn't working [Component] Theme Templates, patterns, CSS labels Sep 12, 2022
@adamwoodnz adamwoodnz force-pushed the fix/120-spacing branch 3 times, most recently from b095d3f to f518b2c Compare September 12, 2022 22:16
- Spacing variables which are supposed to come from the parent theme are undefined
@glendaviesnz
Copy link

@adamwoodnz it would be good to try and work out why those spacing vars are not getting passed to the child theme before the new spacing presets go into 6.1 - I will try and take a look at that today/tomorrow

@adamwoodnz
Copy link
Contributor Author

Closing as the issue has been resolved by reinstalling the Gutenberg plugin

@adamwoodnz adamwoodnz closed this Sep 12, 2022
@adamwoodnz adamwoodnz deleted the fix/120-spacing branch September 12, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme Templates, patterns, CSS [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix spacing issues on wordpress.org
2 participants