-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine header styles #5
Conversation
36de41e
to
827a9c9
Compare
This doesn't include the search or mobile menu, those will be in future PRs. It's also not trying to be pixel perfect yet, just getting the bulk of it done. One problem I ran into is that adding Patterns and Openverse to the header made it too big to fit the design breakpoints. I tested out a submenu for the "resource" type links, and I think it works pretty well: I'm curious to hear what others think, though. cc @beafialho |
I like this solution @iandunn. Regarding the term "Add-ons", my only comment is I think it makes more sense to label it "Resources". The term Add-ons might be mistaken by some users not as familiar with WP as referring only to tools you can add to your site, whereas Resources feels broader with all the items you need to build your site. |
That's a good point, we definitely want to communicate both add and build. Do you think people will make the connection between those actions and "Resources", though? If I saw it, I'd assume it refers more to things like documentation or support. Is there a word that's more descriptive than both "Addons" and "Resources"? |
That's also a good point. I've noticed that the current "Support" page links to Documentation, so maybe the label would be "Support" and Documentation, Forums and Guidelines would be its submenus? There is also "Tools" instead of "Resources". |
I agree that'd be ideal. IIRC, though, the forums are intentionally a little hard to find, because the support team was overwhelmed by folks who didn't try to read docs first. The idea is to encourage folks to "self-serve" a bit before asking for other people's time.
🤔 I think that's a good one for plugins, but doesn't work as well for Themes, Patterns, Blocks, and Images/Openverse. Maybe it'd be good to have a discussion on the designp2, and xpost to a few other teams, to get more perspectives on it? I think it'll be hard to come up with a good word with just a few people. The News site isn't going to launch fo awhile, so we have plenty of time. |
827a9c9
to
0cba05c
Compare
i applied corey's suggestions in 2be4821 i went ahead and merged this w/ the add-on menu, b/c it's easier when we don't have lots of open interconnected prs. i'll switch to the |
see WordPress/wporg-news-2021#6
interconnected with WordPress/wporg-news-2021#28