Map: Merge event filters block #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandunn
force-pushed
the
merge-map-blocks
branch
from
7a27535
to
3573f7c
Compare
In hindsight, it's much simpler to have this as part of the main block rather than having a second. This fixes a rendering bug that is caused by wrapping the main block, and prevents having to build support for block styles into the wrapper block.
iandunn
force-pushed
the
merge-map-blocks
branch
from
3573f7c
to
749f130
Compare
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #500
In hindsight, it's much simpler to have this as part of the main block rather than having a second. This fixes a rendering bug that is caused by wrapping the main block, and prevents having to build support for block styles into the wrapper block.