Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output message when no ratings exist. #656

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

StevenDufresne
Copy link
Contributor

@StevenDufresne StevenDufresne commented Oct 4, 2024

See: WordPress/wordpress.org#380

This block doesn't have any view when no ratings exist.

Before After
Screenshot 2024-10-07 at 10 38 53 AM Screenshot 2024-10-07 at 10 38 43 AM

@StevenDufresne
Copy link
Contributor Author

Looking at our language, we also appear to use Ratings and Reviews interchangeably. I wonder if we want to update that.

@ryelle
Copy link
Contributor

ryelle commented Oct 7, 2024

Currently plugins with no reviews say "This plugin has not been rated yet." (example). Could be generalized to "This has not been rated yet." ?

That said, I think we generally use "reviews" for the whole "unit of feedback", text and number, while ratings are just the numbers. If not, I think we could standardize on that. So this string could be "No reviews have been submitted yet", with the "Add my review" link under it.

@StevenDufresne StevenDufresne merged commit dd79b17 into trunk Oct 23, 2024
2 checks passed
@StevenDufresne StevenDufresne deleted the fix/ratings-bars-no-reviews branch October 23, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants