Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract variables for DRYness #197

Merged
merged 8 commits into from
May 31, 2023
Merged

Extract variables for DRYness #197

merged 8 commits into from
May 31, 2023

Conversation

renintw
Copy link
Contributor

@renintw renintw commented May 29, 2023 •
edited
Loading

This PR is separated from #189, aiming to enhance readability and avoid DRY.
It also extracts the webAuthnEnabled, which was added lately to trunk.

@renintw renintw mentioned this pull request May 29, 2023
Merged
@renintw renintw self-assigned this May 29, 2023
@renintw renintw added the enhancement New feature or request label May 29, 2023
@renintw renintw requested review from iandunn and StevenDufresne May 29, 2023 23:37
@renintw renintw added this to the Iteration 1 milestone May 30, 2023
@StevenDufresne StevenDufresne requested a review from adamwoodnz May 30, 2023 03:49
@renintw renintw force-pushed the enhancement/extract-variables-for-DRY branch from 91ef2d8 to a2fdfb7 Compare May 30, 2023 09:30
adamwoodnz
adamwoodnz reviewed May 30, 2023
View reviewed changes
@adamwoodnz
Copy link
Contributor

Hmm doesn't look like we're running JS tests on PRs

@renintw
Copy link
Contributor Author

renintw commented May 30, 2023 •
edited
Loading

Hmm doesn't look like we're running JS tests on PRs

Hmm, I hadn't realized it until you pointed it out. Turns out only the PHP tests are being run.
I've tested it locally and tests are passed like you said, though.

@renintw
Copy link
Contributor Author

renintw commented May 31, 2023

Hmm doesn't look like we're running JS tests on PRs

Issue added: #201

adamwoodnz
adamwoodnz approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@adamwoodnz adamwoodnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@renintw renintw merged commit 5b78658 into trunk May 31, 2023
@renintw renintw deleted the enhancement/extract-variables-for-DRY branch May 31, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwoodnz adamwoodnz adamwoodnz approved these changes

@iandunn iandunn Awaiting requested review from iandunn

@StevenDufresne StevenDufresne Awaiting requested review from StevenDufresne

Assignees

@renintw renintw

Labels
enhancement New feature or request
Projects
None yet
Milestone
Iteration 1
Development

Successfully merging this pull request may close these issues.
2 participants
@renintw @adamwoodnz