Skip to content

Commit

Permalink
feat: Remove QUESTION comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jimcasey committed Jan 3, 2024
1 parent dff6269 commit 0b26b11
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 11 deletions.
2 changes: 0 additions & 2 deletions modules/react/loading-sparkles/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,3 @@
View the
[documentation for Loading Sparkles](https://workday.github.io/canvas-kit/?path=/docs/components-indicators-loading-sparkles-react--basic)
on Storybook.

<!-- QUESTION: Do we want to add any reference to usage of AI-related components? -->
4 changes: 2 additions & 2 deletions modules/react/loading-sparkles/lib/LoadingSparkles.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,11 @@ const Sparkle = ({animationDelay = 0}: SparkleProps) => (
*/
const Container = styled('div')({
display: 'inline-flex',
gap: '1px', // QUESTION: is there an appropriate rem or space value for this?
gap: '1px',
});

/**
* A simple component that displays three horizontal sparkles, to be used when an AI operation is loading.
* A simple component that displays three horizontal sparkles, to be used when an AI operation is in progress.
*/
export const LoadingSparkles = (props: React.HTMLAttributes<HTMLDivElement>) => {
return (
Expand Down
1 change: 0 additions & 1 deletion modules/react/loading-sparkles/lib/sparkleStage0Icon.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// QUESTION: Should these icons be included in @workday/canvas-system-icons-web instead?
import {CanvasSystemIcon, CanvasIconTypes} from '@workday/design-assets-types';

export const sparkleStage0Icon: CanvasSystemIcon = {
Expand Down
1 change: 0 additions & 1 deletion modules/react/loading-sparkles/lib/sparkleStage1Icon.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// QUESTION: Should these icons be included in @workday/canvas-system-icons-web instead?
import {CanvasSystemIcon, CanvasIconTypes} from '@workday/design-assets-types';

export const sparkleStage1Icon: CanvasSystemIcon = {
Expand Down
1 change: 0 additions & 1 deletion modules/react/loading-sparkles/lib/sparkleStage2Icon.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
// QUESTION: Should these icons be included in @workday/canvas-system-icons-web instead?
import {CanvasSystemIcon, CanvasIconTypes} from '@workday/design-assets-types';

export const sparkleStage2Icon: CanvasSystemIcon = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ import {Accessible} from './examples/Accessible';

# Canvas Kit Loading Sparkles

Loading Sparkles make users aware that content is currently being loaded, processing, or that change
will occur on the page.

<!-- QUESTION: Do we want to add any reference to usage of AI-related components? -->
Loading Sparkles make users aware that an AI operation is in progress.

## Installation

Expand Down

0 comments on commit 0b26b11

Please sign in to comment.