Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handleCsProp was returning a class name when the style attribute was added to an element instead of the style object #2452

Closed
mannycarrera4 opened this issue Dec 7, 2023 · 0 comments · Fixed by #2453
Closed

handleCsProp was returning a class name when the style attribute was added to an element instead of the style object #2452

mannycarrera4 opened this issue Dec 7, 2023 · 0 comments · Fixed by #2453
Assignees
@NicholasBoll
Labels
10.x bug Something isn't working

Comments

@mannycarrera4
Copy link
Contributor

🐛 Bug Report

When a component was using the style attribute, handleCSProp was returning a className instead of merging in those styles. Also, handleCSprop was not merging the style object passed to a component and instead, returning an empty object.
@mannycarrera4 mannycarrera4 added the bug Something isn't working label Dec 7, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Canvas Kit Dec 7, 2023
@mannycarrera4 mannycarrera4 moved this from 🆕 New to 🏗 In progress in Canvas Kit Dec 7, 2023
@NicholasBoll NicholasBoll mentioned this issue Dec 7, 2023
Merged
8 tasks
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Canvas Kit Dec 7, 2023
alanbsmith pushed a commit that referenced this issue Dec 7, 2023
@NicholasBoll
fix: Fix forwarding of the style attribute (#2453)
22a452c 
Fixes: #2452

The `style` attribute was being converted into a class name. The styles were being added and passing visual tests, but doing so in an unoptimized way. We use the `style` attribute for styles that change frequently to avoid expensive Style recalculations and we accidentally broke that.

[category:Components]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicholasBoll NicholasBoll

Labels
10.x bug Something isn't working
Projects
Canvas Kit
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Fix forwarding of the style attribute NicholasBoll/canvas-kit
2 participants
@NicholasBoll @mannycarrera4