fix: Fix forwarding of the style attribute #2453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mannycarrera4
approved these changes
Dec 7, 2023
NicholasBoll
commented
Dec 7, 2023
| @@ -1,8 +1,8 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Remove the React dependency. It was unintentional.
NicholasBoll
commented
Dec 7, 2023
| const returnProps = csToProps([localCs, className, cs, style]); | ||
| const returnProps = csToProps([localCs, className, cs]); |
There was a problem hiding this comment.
Adding style to the csToProps was always weird. But before we added support for static inline styles, it worked. Afterwards, csToProps couldn't differentiate between a style prop given from elemProps or one given by a createVars function or a Stencil. So I removed style from the array and merge it below instead.
1 flaky test on run #6511 ↗︎
Details:
Review all test suite changes for PR #2453 ↗︎ |
||||||||||||||||||||
NicholasBoll
added
automerge
and removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #2452
The
styleattribute was being converted into a class name. The styles were being added and passing visual tests, but doing so in an unoptimized way. We use thestyleattribute for styles that change frequently to avoid expensive Style recalculations and we accidentally broke that.Release Category
Components
Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
You could try adding a
styleattribute to any example. Without this change, the style attribute gets removed and the styles get merged into the element's main CSS class.