fix: Remove action tokens from CanvasProvider to allow cascading #3125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
mc-remove-action-token
|
| Run status |
|
| Run duration | 02m 49s |
| Commit |
|
| Committer | Manuel Carrera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
929
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.28%
|
|
|---|---|
|
Untested elements
|
1522
|
|
Tested elements
|
409
|
Accessibility
99.17%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
162
|
josh-bagwell
reviewed
Feb 6, 2025
| if (color === 'common') { | ||
| (['common', 'primary', 'error', 'alert', 'success', 'neutral'] as const).forEach(color => { | ||
| if (color === 'common') { | ||
| // @ts-ignore |
There was a problem hiding this comment.
What is TS complaining about here?
There was a problem hiding this comment.
There was a problem hiding this comment.
It looks like a Prettier reformat. 'action' was removed from the array and that shortened the line enough.
NicholasBoll
approved these changes
Feb 6, 2025
mannycarrera4
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3121
Release Category
Theming
Release Note
The
CanvasProvidercreated a cascading barrier for our brand tokens. In the case wherebrand.action.**tokens are defined at the root level, say:rootin a a CSS file, we want those tokens to cascade through theCanvasProviderdown to ourPrimaryButton's. To allow this, we've removed them from theCanvasProviderandvariables.css.@workday/[email protected]removed--cnvs-brand-action-**tokens from ourvariables.cssto ensure proper cascading of this token to theme ourPrimaryButton's.CanvasProviderhas removed defaultingbrand.action.**for theming and is longer a valid theme property onCanvasThemetype.--cnvs-brand-action-**token, you must upgrade to the latest version of Canvas Kitv12and whomever is bootstrapping thevariables.cssmust upgrade@workday/canvas-tokens-webto@2.1.1to ensure correct theming.Checklist
ready for reviewhas been added to PRFor the Reviewer
Where Should the Reviewer Start?
Areas for Feedback? (optional)
Testing Manually
Screenshots or GIFs (if applicable)
Thank You Gif (optional)