feat: Add simple or HTML Variant to Table #3126
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workday/canvas-kit
|
||||||||||||||||||||||||||||||||||||||||
| Project |
Workday/canvas-kit
|
| Branch Review |
simple-table-variant-25-02
|
| Run status |
|
| Run duration | 02m 50s |
| Commit |
|
| Committer | Josh |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
934
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
21.37%
|
|
|---|---|
|
Untested elements
|
1518
|
|
Tested elements
|
410
|
Accessibility
99.17%
|
|
|---|---|
|
Failed rules
|
6 critical
5 serious
0 moderate
2 minor
|
|
Failed elements
|
162
|
modules/react/table/lib/Table.tsx
Outdated
| /** | ||
| * Variant has an option for `simple` which will have the Table act as a HTML Table without Grid styles. | ||
| */ | ||
| variant?: 'html'; |
There was a problem hiding this comment.
Maybe this is table | grid with the default being gird? Not sure html conveys that it behaves like a default html table element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #3048
Add a "simple" or "html" variant to
Table.Users have been asking about getting a simple
Tableto use withoutGridstyling. This addresses that and gives them a simple HTMLTable.Release Category
Components
Release Note
Addition of a HTML variant for
Table. This will be a standard HTMLTable.Where Should the Reviewer Start?
/modules/react/table