Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lazyTokenizeSentences #137

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Use lazyTokenizeSentences #137

merged 3 commits into from
Jul 2, 2024

Conversation

mh-northlander
Copy link
Collaborator

@mh-northlander mh-northlander commented Jun 26, 2024 •
edited
Loading

fix #136

  • This PR uses unreleased feature of Sudachi (Tokenizer.lazyTokenizeSentences)
    • Update sudachi dependency to v0.7.4

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mh-northlander mh-northlander changed the title WIP: use lazy analysis Use lazyTokenizeSentences Jul 2, 2024
@mh-northlander mh-northlander requested a review from kazuma-t July 2, 2024 07:48
@mh-northlander mh-northlander merged commit f9768ad into develop Jul 2, 2024
25 checks passed
@mh-northlander mh-northlander deleted the feature/lazy-sudachi-analysis branch July 2, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazuma-t kazuma-t kazuma-t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analysis may corrupt around the chunk edge
2 participants
@mh-northlander @kazuma-t