Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] POI editable layer #195

Merged
merged 13 commits into from
Oct 25, 2017
Merged

[WIP] POI editable layer #195

merged 13 commits into from
Oct 25, 2017

Conversation

danielfdsilva
Copy link
Collaborator

@danielfdsilva danielfdsilva commented Oct 20, 2017 •
edited
Loading

This PR adds the ability to import POIs into iD and edit them.

Things todo:

  • Modify iD to better work with RAM POIs (make it easy to select the options of the custom field ram_poi_type)
    • Limit the options to the poi types existing in the system
    • Require the ram_poi_type to be set
  • Add tests for the scenario creation taking poi source into account

Accompanying frontend pr WorldBank-Transport/ram-frontend#162

@danielfdsilva
Copy link
Collaborator Author

The conflicts have to be resolved after the other PRs are merged

@olafveerman olafveerman mentioned this pull request Oct 25, 2017
Merged
@olafveerman
Copy link
Contributor

Merging this and tracking the remaining items through these tickets:

@olafveerman olafveerman merged commit 591c328 into develop Oct 25, 2017
@danielfdsilva danielfdsilva deleted the feature/poi-import branch March 20, 2018 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielfdsilva @olafveerman