Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for wbcatalog source #216

Merged
merged 49 commits into from
Oct 3, 2018
Merged

Add support for wbcatalog source #216

merged 49 commits into from
Oct 3, 2018

Conversation

danielfdsilva
Copy link
Collaborator

No description provided.

@danielfdsilva danielfdsilva mentioned this pull request Apr 13, 2018
Merged
@danielfdsilva
Copy link
Collaborator Author

danielfdsilva commented Apr 17, 2018 •
edited
Loading

Base structure for the WB catalog integration.

TODO:

  • Integrate with the catalog endpoint to index resources
  • Get the data from the catalog when creating a scenario

These depend on some changes needed on the catalog. See #214

@olafveerman
Copy link
Contributor

This can be tested with:

tag: ram-rn
https://datacatalog.worldbank.org/dataset/roads-gambia

tag: ram-admin
https://datacatalog.worldbank.org/dataset/rwanda-admin-boundaries-and-villages

@danielfdsilva

@olafveerman
Copy link
Contributor

@danielfdsilva Please rebase this branch with develop. Had to force update it to purge the bu config files.

@danielfdsilva danielfdsilva force-pushed the feature/wbcatalog branch 12 times, most recently from a1e81d7 to dcc4ab1 Compare June 19, 2018 09:57
@danielfdsilva danielfdsilva changed the title [WIP] Add support for wbcatalog source Add support for wbcatalog source Jun 20, 2018
@danielfdsilva
Copy link
Collaborator Author

@olafveerman I think we should implement this #225 to finish this feature, but it should be ready to test.

vgeorge and others added 26 commits September 14, 2018 13:28
@vgeorge
Fix link to container at docker hub and update yarn.lock
1a0e162
@danielfdsilva
Address review
bdc392f
@danielfdsilva
Add support for object spread notation
5ad20d1
@danielfdsilva
Refactor function
2061240
@danielfdsilva
Add new error handling system for try catch blocks
81e944f
@danielfdsilva
Extract main code from handler
68321ad 
In the process move code to async / await :D
@danielfdsilva
Export project results in faux feature format to feed rah map
4c12a2a
@danielfdsilva
Flatten contact
5f6305e
@danielfdsilva
Allow not exporting results
c5a3092 
Contribute to WorldBank-Transport/rah#37
@danielfdsilva
Include mention to moderators to send out notifications
03cbba3 
Fix WorldBank-Transport/rah#29
@olafveerman
Merge pull request #233 from WorldBank-Transport/feature/rah-map-data
09aff5c 
RAH map data
@olafveerman
Merge pull request #232 from WorldBank-Transport/feature/profile-editor
ce34381 
Profile Editor
@danielfdsilva
Fix wbcatalog data stored in database
5ecb79f
@danielfdsilva
Fix scenario files being deleted after in between imports
93cce21
@danielfdsilva
Handle non Point POI when importing to osm-p2p
f905e3c 
Also convert rra-osm-p2p to async/await
@danielfdsilva
Fix waitForEvents.
767349b 
Tt would wait indefinitely because the event had been emitted when the listener was added
@danielfdsilva
Add support for wbcatalog datasets with multiple resources
0d2fd6f
@danielfdsilva
Handle race condition on operations
5b431cb
@danielfdsilva
Streamline error handling
73b2fd1 
Using async/await on operations didn't play nice with bluebird Promises. This is also a more vanilla way of handling things
@danielfdsilva
Fix typo
ffb249b
@danielfdsilva
Disable rn from wb catalog
adf94a4
@danielfdsilva
Include project name on RAH folder export. Fix result inclusion option
58e8191
@danielfdsilva
Refactor results endpoint to include population totals
03a69dc
@danielfdsilva
Convert scenario--results to async/await
38ecc37
@danielfdsilva
Use promise to correctly handle async loops
c3b6d58
@danielfdsilva
Fix log
38a6931
@olafveerman
Copy link
Contributor

olafveerman commented Oct 2, 2018 •
edited
Loading

@danielfdsilva Tested the back- and frontend of the Data Catalog. I get the stack up and running and the form looks good. When I select the Catalog as a data source, none of the categories show datasets that can be imported (I changed the empty text):

image

Anything I missed on my end?

@danielfdsilva
Copy link
Collaborator Author

danielfdsilva commented Oct 3, 2018 •
edited
Loading

@olafveerman There was another PR open #234 that merged into this one and fixed a couple of issues. I fast-forwarded this branch and now should be all good.

@olafveerman olafveerman merged commit 40ca7c7 into develop Oct 3, 2018
@olafveerman olafveerman deleted the feature/wbcatalog branch October 3, 2018 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielfdsilva @olafveerman @vgeorge