Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Editor #232

Merged
merged 15 commits into from
Sep 21, 2018
Merged

Profile Editor #232

merged 15 commits into from
Sep 21, 2018

Conversation

danielfdsilva
Copy link
Collaborator

This PR adds profile editing capabilities fixing #229.
In light of #231 the api does not support multi level speed objects even thought the frontend is ready to support them.


Because of all the changes that were made to source data management, I had to branch from feature/wbcatalog otherwise I'd be developing on top of old code and creating conflicts.
This PR should only be merged after #216

Copy link
Collaborator

@vgeorge vgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is very readable and well structured, and I could edit profile data in the frontend. My only suggestion here is to use module lua-fmt to check if the resulting profile is valid.

@danielfdsilva danielfdsilva mentioned this pull request Sep 17, 2018
@vgeorge
Copy link
Collaborator

vgeorge commented Sep 21, 2018

I've reviewed the latest commits, ready to be merged.

@olafveerman olafveerman merged commit ce34381 into feature/wbcatalog Sep 21, 2018
@olafveerman olafveerman deleted the feature/profile-editor branch September 21, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants