-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Profile Editor #232
Merged
Merged
Profile Editor #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfdsilva
force-pushed
the
feature/profile-editor
branch
from
September 13, 2018 14:19
2a19bae
to
42ff97d
Compare
vgeorge
reviewed
Sep 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is very readable and well structured, and I could edit profile data in the frontend. My only suggestion here is to use module lua-fmt to check if the resulting profile is valid.
Merged
In the process move code to async / await :D
Contribute to WorldBank-Transport/rah#37
I've reviewed the latest commits, ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds profile editing capabilities fixing #229.
In light of #231 the api does not support multi level speed objects even thought the frontend is ready to support them.
Because of all the changes that were made to source data management, I had to branch from
feature/wbcatalog
otherwise I'd be developing on top of old code and creating conflicts.This PR should only be merged after #216