Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version number defined in Yaml everywhere #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use version number defined in Yaml everywhere #33

wants to merge 2 commits into from

Conversation

ichthyosaurus
Copy link

No description provided.

@Wunderfitz
Copy link
Owner

It only seems to work when I do a clean build. A delta build (e.g. via the Sailfish OS IDE) doesn't seem to update the version number properly. Any ideas/comments?

@Wunderfitz Wunderfitz self-requested a review July 5, 2020 18:06
Wunderfitz
Wunderfitz requested changes Jul 5, 2020
View reviewed changes
Copy link
Owner

@Wunderfitz Wunderfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the previous comment - it needs to work in a delta build before it can be merged.

@ichthyosaurus
Copy link
Author

I decided to go this way because the alternative would mean to re-build harbour-wunderfitz.cpp every time. (I always do a clean build before a release, so it was no problem for me.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wunderfitz Wunderfitz Awaiting requested review from Wunderfitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ichthyosaurus @Wunderfitz