Don't consider function for ASAN #1932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ge25519_scalarmult_base_choose_niels leads to errors (XRPLF#1668) when compiled with address sanitizer.
Current coverage is 65.46% (diff: 100%)@@ develop #1932 diff @@
==========================================
Files 698 698
Lines 49745 49745
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 32562 32564 +2
+ Misses 17183 17181 -2
Partials 0 0
|
|
I'm not sure if we really want to modify the donna sources. Maybe this should be submitted to upstream? |
|
Last commit is from nearly 2 years ago and they also didn't merge floodyberry/ed25519-donna#21 yet which is from 2014. I can try submitting there, but the project seems a bit stale (or mature/finished, depending on PoV). |
|
I'll mark this as passed, because it's good to be able to run ASAN builds without false positives. |
nbougalis
added
the
Ready to merge
|
Merged as a550072. Thank you for the contribution Markus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ge25519_scalarmult_base_choose_niels leads to errors (#1668) when compiled with address sanitizer.
Solution from http://stackoverflow.com/a/27982389
Original bug: #1668