BalanceChanges rename issuer to counterparty

XRPLWin · Nov 2, 2022 · 47a6c7e · 47a6c7e
1 parent e3cb108
commit 47a6c7e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 21 deletions.
diff --git a/src/Utilities/BalanceChanges.php b/src/Utilities/BalanceChanges.php
@@ -112,7 +112,7 @@ private function getTrustlineQuantity(\stdClass $node): ?array
     $result = [
       'account' => (isset($fields->LowLimit->issuer)) ? $fields->LowLimit->issuer : '',
       'balance' => [
-        'issuer' => (isset($fields->HighLimit->issuer)) ? $fields->HighLimit->issuer : '',
+        'counterparty' => (isset($fields->HighLimit->issuer)) ? $fields->HighLimit->issuer : '',
         'currency' => (isset($fields->Balance->currency)) ? $fields->Balance->currency : '',
         'value' => (string)$value->stripTrailingZeros(),
       ]
@@ -155,9 +155,9 @@ private function flipTrustlinePerspective(array $balanceChange): array
   {
     $negatedBalance = BigDecimal::of($balanceChange['balance']['value'])->negated();
     $result = [
-      'account' => $balanceChange['balance']['issuer'],
+      'account' => $balanceChange['balance']['counterparty'],
       'balance' => [
-        'issuer' => $balanceChange['account'],
+        'counterparty' => $balanceChange['account'],
         'currency' => $balanceChange['balance']['currency'],
         'value' => (string)$negatedBalance->stripTrailingZeros(),
       ]

diff --git a/tests/Unit/BalanceChangesTest.php b/tests/Unit/BalanceChangesTest.php
@@ -45,7 +45,7 @@ public function test_usd_payment_to_account_with_no_usd()
           [
             'value' => '-0.01',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ],
           [
             'value' => '-0.012',
@@ -59,12 +59,12 @@ public function test_usd_payment_to_account_with_no_usd()
           [
             'value' => '0.01',
             'currency' => 'USD',
-            'issuer' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
+            'counterparty' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
           ],
           [
             'value' => '-0.01',
             'currency' => 'USD',
-            'issuer' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
+            'counterparty' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
           ]
         ]
       ],
@@ -74,7 +74,7 @@ public function test_usd_payment_to_account_with_no_usd()
           [
             'value' => '0.01',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ]
         ]
       ]
@@ -97,7 +97,7 @@ public function test_payment_of_all_usd_in_source_account()
           [
             'value' => '0.2',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ]
         ]
       ],
@@ -107,12 +107,12 @@ public function test_payment_of_all_usd_in_source_account()
           [
             'value' => '-0.2',
             'currency' => 'USD',
-            'issuer' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
+            'counterparty' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
           ],
           [
             'value' => '0.2',
             'currency' => 'USD',
-            'issuer' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
+            'counterparty' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
           ]
         ]
       ],
@@ -122,7 +122,7 @@ public function test_payment_of_all_usd_in_source_account()
           [
             'value' => '-0.2',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ],
           [
             'value' => '-0.012',
@@ -149,7 +149,7 @@ public function test_usd_payment_to_account_with_usd()
           [
             'value' => '-0.01',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ],
           [
             'value' => '-0.012',
@@ -163,12 +163,12 @@ public function test_usd_payment_to_account_with_usd()
           [
             'value' => '0.01',
             'currency' => 'USD',
-            'issuer' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
+            'counterparty' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
           ],
           [
             'value' => '-0.01',
             'currency' => 'USD',
-            'issuer' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
+            'counterparty' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
           ]
         ]
       ],
@@ -178,7 +178,7 @@ public function test_usd_payment_to_account_with_usd()
           [
             'value' => '0.01',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ]
         ]
       ]
@@ -223,7 +223,7 @@ public function test_create_trustline()
           [
             'value' => '10',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q',
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q',
           ],
           [
             'value' => '-0.012',
@@ -237,7 +237,7 @@ public function test_create_trustline()
           [
             'value' => '-10',
             'currency' => 'USD',
-            'issuer' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K',
+            'counterparty' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K',
           ]
         ]
       ]
@@ -304,7 +304,7 @@ public function test_delete_trustline()
           [
             'value' => '0.02',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ]
         ],
       ],
@@ -314,12 +314,12 @@ public function test_delete_trustline()
           [
             'value' => '-0.02',
             'currency' => 'USD',
-            'issuer' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
+            'counterparty' => 'rKmBGxocj9Abgy25J51Mk1iqFzW9aVF9Tc'
           ],
           [
             'value' => '0.02',
             'currency' => 'USD',
-            'issuer' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
+            'counterparty' => 'rLDYrujdKUfVx28T9vRDAbyJ7G2WVXKo4K'
           ]
         ]
       ],
@@ -329,7 +329,7 @@ public function test_delete_trustline()
           [
             'value' => '-0.02',
             'currency' => 'USD',
-            'issuer' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
+            'counterparty' => 'rMwjYedjc7qqtKYVLiAccJSmCwih4LnE2q'
           ],
           [
             'value' => '-0.012',