-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repair broken links, and some files shouldn't exist #468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议, 有一个项目级别的tabSize设置, 防止后来的维护者或者开发者, 在本地保存的时候, 可能会被强制格式化为4个空格, 2个空格, 或者一个tab.
项目级别的tabSize设置, 可以使得各个角色的代码一致性更好.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没见过搞这个的
而且也不是通过一个.vscode啊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经有 workflow 做这个了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stackoverflow.com/questions/32964920/should-i-commit-the-vscode-folder-to-source-control
I think it is ok to keep settings in source
再ping一下 抛开这些 这里最主要是fix一个问题 比如说 https://xtls.github.io/config/#%E5%9F%BA%E7%A1%80%E9%85%8D%E7%BD%AE%E6%A8%A1%E5%9D%97 下面的帮助我们改善此界面直接跳到 https://github.com/xtls/xray-core/edit/main/docs/config/README.md 去了 这个pr主要是处理这个问题 几天前坏到现在 |
确实都可以 既然 @aoleou 已经是文档管理员了 |
wtf |
我工作中确实遇到过同事给我们详细介绍了 .ide 文件夹里有些文件不能check in 有些则应该check in 然后还在CI 里面做了check in 之前的各种格式,commit message 的检查 |
我非常欣赏风扇哥的执着. 说一下我的结论: 这个 Xray-docs-next 项目, 最核心的资产是文档内容. 那些基础配置, 都是复制粘贴过来的. 既然风扇哥,想合并,那就合并好了, 后面我得空了, 简单加上husky也一样可以实现我想要的需求, 而且更好. @yuhan6665 |
好的 希望这个项目能给大家在专业/兴趣中也获得一些意想不到的收获 |
删掉的都是vscode产生的配置文件
顺便帮助我们改善此界面坏掉了 因为本来好好的配置被放到了locales下面(¿)