Merge pull request #30 from XanderD99/28-value-is-not-a-valid-number-nan

correctly check response and request content length
XanderD99 · Dec 9, 2024 · 70a5f7e · 70a5f7e
2 parents cdb8f10 + 1a94ffd
commit 70a5f7e
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/server/src/middlewares/metrics.ts b/server/src/middlewares/metrics.ts
@@ -72,14 +72,20 @@ export default async (ctx, next) => {
 
     httpRequestsTotal.inc({ ...labels, status: ctx.status })
 
-    const requestContentLenght = ctx.request.get('Content-Length') || ctx.request.get('content-length');
-    if (requestContentLenght) {
-      requestContentLengthBytes.observe({ ...labels, status: ctx.status }, parseInt(requestContentLenght));
+    const requestContentLength = ctx.request.get('Content-Length') || ctx.request.get('content-length');
+    if (requestContentLength) {
+      const parsedRequestContentLength = parseInt(requestContentLength, 10);
+      if (!isNaN(parsedRequestContentLength) && isFinite(parsedRequestContentLength)) {
+        requestContentLengthBytes.observe({ ...labels, status: ctx.status }, parsedRequestContentLength);
+      }
     }
-
-    const responseConentLength = ctx.response.get('Content-Length') || ctx.response.get('content-length');
-    if (requestContentLenght) {
-      responseContentLengthBytes.observe({ ...labels, status: ctx.status }, parseInt(responseConentLength));
+
+    const responseContentLength = ctx.response.get('Content-Length') || ctx.response.get('content-length');
+    if (responseContentLength) {
+      const parsedResponseContentLength = parseInt(responseContentLength, 10);
+      if (!isNaN(parsedResponseContentLength) && isFinite(parsedResponseContentLength)) {
+        responseContentLengthBytes.observe({ ...labels, status: ctx.status }, parsedResponseContentLength);
+      } 
     }
   });
 };