Winapi reformatting #677
Merged
Winapi reformatting #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracc
reviewed
Sep 9, 2024
| #define INIT_ONCE_CHECK_ONLY 0x00000001UL | ||
| #define INIT_ONCE_ASYNC 0x00000002UL | ||
| #define INIT_ONCE_INIT_FAILED 0x00000004UL | ||
| typedef BOOL(CALLBACK *PINIT_ONCE_FN)(PINIT_ONCE, PVOID, PVOID *); |
There was a problem hiding this comment.
Does removing the white-spaces here not change the behavior?
There was a problem hiding this comment.
That can be the case with #defines, where there must not be a whitespace between the name and parameter list for function-style macros, but typedef isn't sensitive to whitespace changes.
There was a problem hiding this comment.
Well, in that case I have no qualms for a merge.
dracc
reviewed
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit of a follow-up to #670, reformats all the winapi code to comply with the
.clang-formatRyzee added.Also utilizing
.git-blame-ignore-revs, so this reformatting won't mess up the blame view (as long as this PR doesn't get rebased which would change the commit hash), https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view has more info on how that works.