-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change known gte asm files to asm #2160
Conversation
No controversy here, I think this was the very first thing I worked on as it was at the top of the functions list and I thought it "easiest". Before I understood this is not technically SOTN code. Change makes sense to me |
I remember @ser-pounce was looking at InitGeom, should get approval from them too |
I think any direction is fine for these as long as it's consistent. As the raw assembly can be somewhat simplified, should they be marked as |
It seems like hasm doesn't include the preamble stuff?
|
Seems like that's the current version of splat, because if we were using it it should also generate the preamble for .hasm. This commit seems to have been the one that changed how splat handled the generation so presumably anything earlier will fail as in your log It could be worked around by adding |
There's some sort of splat bug or something with 26.1 and greater
I suppose what could be done is including the asm as actual files in the repo and adding the appropriate prelude |
We know all of these are handwritten asm from dumping the libs. Script + results here: https://gist.github.com/sozud/6f5d111c49b69fd7b1c0c812067b2eeb Change these to asm so people don't waste time trying to match them. The changes to src/main/psxsdk/libgte/reg03.c may be controversial since someone found a C match for it, but it's not going to match the original object. @JoshSchreuder Seems to have done most of the work on that file
We know all of these are handwritten asm from dumping the libs. Script + results here: https://gist.github.com/sozud/6f5d111c49b69fd7b1c0c812067b2eeb
Change these to asm so people don't waste time trying to match them. The changes to src/main/psxsdk/libgte/reg03.c may be controversial since someone found a C match for it, but it's not going to match the original object. @JoshSchreuder Seems to have done most of the work on that file