Dedupe lib e_lock_camera + st_debug
#2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshSchreuder
commented
Feb 19, 2025
| s16 unk84; | ||
| s16 unk86; | ||
| u16 unk88; | ||
| u16 unk8A; |
There was a problem hiding this comment.
I think all of the existing unkid12 code can and should use this extension struct, and I'll update them in the next PR refactor
sozud
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing this I found a lot of very similar code in entity_unk_id12.h and entity_lock_camera.h.
I am going to put up a separate PR to refactor this stuff, including the extensions, since I think this is really all just variations on
EntityLockCamera, and we can name it as such everywhere. It looks like this function was copied around a lot in the overlays and changed numerous times.