Fix Servant extraction on US #2252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The US build chain does not currently extract the servant overlays properly due to a minor misspelling on `PSX_US_SERVANTS`. This PR fixes it. I think the reason why it did not impact the CI is because the `$(BUILD_DIR)/tt_%.elf` rule also tries to build `$(BUILD_DIR)/tt_%.ld`. This is wrong as the dependency `$$(call list_o_files,servant/tt_$$*)` right next to it will try to compile C files in search of yet-to-be-extracted nonmatching assembly files, making the whole build system to fail. I think this is only noticeable on high parallelised builds.
sozud
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The US build chain does not currently extract the servant overlays properly due to a minor misspelling on
PSX_US_SERVANTS. This PR fixes it.I think the reason why it did not impact the CI is because the
$(BUILD_DIR)/tt_%.elfrule also tries to build$(BUILD_DIR)/tt_%.ld. This is wrong as the dependency$$(call list_o_files,servant/tt_$$*)right next to it will try to compile C files in search of yet-to-be-extracted nonmatching assembly files, making the whole build system to fail. I think this is only noticeable on high parallelised builds.