Fixing Security Vulnerability for shortcuts (#539)

* Fixing Security Vulnerability for shortcuts * Revert as the fixes didn't work * EncodeURL Co-Authored-By: Prem Kumar <[email protected]> --------- Co-authored-by: Prem Kumar <[email protected]>
XengShi · Feb 18, 2025 · 9be341b · 9be341b
1 parent bf050d8
commit 9be341b
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/scripts/shortcuts.js b/scripts/shortcuts.js
@@ -304,8 +304,10 @@ document.addEventListener("DOMContentLoaded", function () {
             url = "https://xengshi.github.io/materialYouNewTab/docs/PageNotFound.html";
         }
 
-        // Normalize URL if valid
-        const normalizedUrl = url.startsWith('https://') || url.startsWith('http://') ? url : 'https://' + url;
+        // Normalize and encode URL
+        const normalizedUrl = encodeURI(
+            url.startsWith('https://') || url.startsWith('http://') ? url : 'https://' + url
+        );
 
         const i = shortcut._index;